Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting in client side article #413

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Fix formatting in client side article #413

merged 2 commits into from
Dec 18, 2024

Conversation

oscarvz
Copy link
Member

@oscarvz oscarvz commented Dec 17, 2024

Formatting in #399 broke some highlighting & formatting

Copy link

cloudflare-workers-and-pages bot commented Dec 17, 2024

Deploying fpx-www with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8abb690
Status: ✅  Deploy successful!
Preview URL: https://2406db82.fpx-www.pages.dev
Branch Preview URL: https://article-formatting-fix.fpx-www.pages.dev

View logs

@oscarvz oscarvz force-pushed the article-formatting-fix branch from 74d1120 to 0796e42 Compare December 17, 2024 11:41
@brettimus
Copy link
Contributor

yoooo if you want to make the preview deployment work on cloudflare, try cherry-picking this commit onto your branch: 0216c01

@oscarvz oscarvz force-pushed the article-formatting-fix branch from 37ce11f to 8abb690 Compare December 18, 2024 11:00
Copy link
Contributor

@brettimus brettimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry - i was the one who asked lau to run format in the offending pr

we should probably figure out when biome breaks our blog posts and turn off some of those rules

@oscarvz
Copy link
Member Author

oscarvz commented Dec 18, 2024

@brettimus no worries, it's something hard to spot when running a formatter. Thanks for the commit suggestion & review!

@oscarvz oscarvz merged commit 2d428a4 into main Dec 18, 2024
3 checks passed
@oscarvz oscarvz deleted the article-formatting-fix branch December 18, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants